Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions commands/FBTextInputCommands.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
#!/usr/bin/python

# Copyright (c) 2016, Facebook, Inc.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree. An additional grant
# of patent rights can be found in the PATENTS file in the same directory.

import os

import lldb
import fblldbbase as fb
import fblldbviewhelpers as viewHelpers

ACCESSIBILITY_ID = 0
REPLACEMENT_TEXT = 1
INPUT_TEXT = 0


def lldbcommands():
return [
FBInputTexByAccessibilityIdCommand(),
FBInputTexToFirstResponderCommand(),
]


class FBInputTexByAccessibilityIdCommand(fb.FBCommand):
def name(self):
return 'settext'

def description(self):
return 'Set text on text on a view by accessibility id.'

def args(self):
return [
fb.FBCommandArgument(arg='accessibilityId', type='string', help='The accessibility ID of the input view.'),
fb.FBCommandArgument(arg='replacementText', type='string', help='The text to set.')
]

def run(self, arguments, options):
self.findView(rootView(), arguments[ACCESSIBILITY_ID], arguments[REPLACEMENT_TEXT])

def findView(self, view, searchIdentifier, replacementText):
views = subviewsOfView(view)
for index in range(0, viewsCount(views)):
subview = subviewAtIndex(views, index)
self.findView(subview, searchIdentifier, replacementText)
else:
identifier = accessibilityIdentifier(view)
if isEqualToString(identifier, searchIdentifier):
setTextInView(view, replacementText)


class FBInputTexToFirstResponderCommand(fb.FBCommand):
def name(self):
return 'setinput'

def description(self):
return 'Input text into text field or text view that is first responder.'

def args(self):
return [
fb.FBCommandArgument(arg='inputText', type='string', help='The text to input.')
]

def run(self, arguments, options):
self.findFirstResponder(rootView(), arguments[INPUT_TEXT])

def findFirstResponder(self, view, replacementText):
views = subviewsOfView(view)
if isFirstResponder(view):
setTextInView(view, replacementText)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My python is clearly lacking, how does this else: section work? Does it only run if the for loop has nothing to loop over (in this case view count is zero)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's exactly it. My python isn't that great either, only found out about this while writing this code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't handle any first responder that has subviews. Is there a reason for that? I'm not aware of anything that prevents a view with subviews from being first responder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is intended to be used after selecting a text field/text view, making it first responder, then setting the text on it.

With that in mind, if anything else is first responder at the time this command is run it will either do nothing, or set the text property on it.

I took the happy path for this, but I could put checks in the setTextInView function which only set text on classes which respond to setText:.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking back over the code, this branch of code is only executed when a view has no subviews.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch of code is only executed when a view has no subviews.

Right, and I'm wondering about cases where some text input view has internal subviews. There's no guarantee that that a text input view will always have no subviews. I think the isFirstResponder check should go above the loop, and if it fails, then loop over subviews. This would make it breadth first, but I don't see a problem with that, do you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no issue. Pushed it up.

else:
for index in range(0, viewsCount(views)):
subview = subviewAtIndex(views, index)
self.findFirstResponder(subview, replacementText)


# Some helpers
def rootView():
return fb.evaluateObjectExpression('[[UIApplication sharedApplication] keyWindow]')

def subviewsOfView(view):
return fb.evaluateObjectExpression('[%s subviews]' % view)

def subviewAtIndex(views, index):
return fb.evaluateObjectExpression('[%s objectAtIndex:%i]' % (views, index))

def viewsCount(views):
return int(fb.evaluateExpression('(int)[%s count]' % views))

def accessibilityIdentifier(view):
return fb.evaluateObjectExpression('[%s accessibilityIdentifier]' % view)

def isEqualToString(identifier, needle):
return fb.evaluateBooleanExpression('[%s isEqualToString:@"%s"]' % (identifier, needle))

def setTextInView(view, text):
fb.evaluateObjectExpression('[%s setText:@"%s"]' % (view, text))
viewHelpers.flushCoreAnimationTransaction()

def isFirstResponder(view):
return fb.evaluateBooleanExpression('[%s isFirstResponder]' % view)