-
Notifications
You must be signed in to change notification settings - Fork 798
Adding text input command #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ada41c
Adding text input command
tecknut 12a1e2f
Setting text on first responder with input command. Changing previous…
tecknut 018d61e
responding to commends, removing guards
tecknut 30e7cc6
move first responder check above loop
tecknut 2227089
changing command names
tecknut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| #!/usr/bin/python | ||
|
|
||
| # Copyright (c) 2016, Facebook, Inc. | ||
| # All rights reserved. | ||
| # | ||
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. An additional grant | ||
| # of patent rights can be found in the PATENTS file in the same directory. | ||
|
|
||
| import os | ||
|
|
||
| import lldb | ||
| import fblldbbase as fb | ||
| import fblldbviewhelpers as viewHelpers | ||
|
|
||
| ACCESSIBILITY_ID = 0 | ||
| REPLACEMENT_TEXT = 1 | ||
| INPUT_TEXT = 0 | ||
|
|
||
|
|
||
| def lldbcommands(): | ||
| return [ | ||
| FBInputTexByAccessibilityIdCommand(), | ||
| FBInputTexToFirstResponderCommand(), | ||
| ] | ||
|
|
||
|
|
||
| class FBInputTexByAccessibilityIdCommand(fb.FBCommand): | ||
| def name(self): | ||
| return 'settext' | ||
|
|
||
| def description(self): | ||
| return 'Set text on text on a view by accessibility id.' | ||
|
|
||
| def args(self): | ||
| return [ | ||
| fb.FBCommandArgument(arg='accessibilityId', type='string', help='The accessibility ID of the input view.'), | ||
| fb.FBCommandArgument(arg='replacementText', type='string', help='The text to set.') | ||
| ] | ||
|
|
||
| def run(self, arguments, options): | ||
| self.findView(rootView(), arguments[ACCESSIBILITY_ID], arguments[REPLACEMENT_TEXT]) | ||
|
|
||
| def findView(self, view, searchIdentifier, replacementText): | ||
| views = subviewsOfView(view) | ||
| for index in range(0, viewsCount(views)): | ||
| subview = subviewAtIndex(views, index) | ||
| self.findView(subview, searchIdentifier, replacementText) | ||
| else: | ||
| identifier = accessibilityIdentifier(view) | ||
| if isEqualToString(identifier, searchIdentifier): | ||
| setTextInView(view, replacementText) | ||
|
|
||
|
|
||
| class FBInputTexToFirstResponderCommand(fb.FBCommand): | ||
| def name(self): | ||
| return 'setinput' | ||
|
|
||
| def description(self): | ||
| return 'Input text into text field or text view that is first responder.' | ||
|
|
||
| def args(self): | ||
| return [ | ||
| fb.FBCommandArgument(arg='inputText', type='string', help='The text to input.') | ||
| ] | ||
|
|
||
| def run(self, arguments, options): | ||
| self.findFirstResponder(rootView(), arguments[INPUT_TEXT]) | ||
|
|
||
| def findFirstResponder(self, view, replacementText): | ||
| views = subviewsOfView(view) | ||
| if isFirstResponder(view): | ||
| setTextInView(view, replacementText) | ||
| else: | ||
| for index in range(0, viewsCount(views)): | ||
| subview = subviewAtIndex(views, index) | ||
| self.findFirstResponder(subview, replacementText) | ||
|
|
||
|
|
||
| # Some helpers | ||
| def rootView(): | ||
| return fb.evaluateObjectExpression('[[UIApplication sharedApplication] keyWindow]') | ||
|
|
||
| def subviewsOfView(view): | ||
| return fb.evaluateObjectExpression('[%s subviews]' % view) | ||
|
|
||
| def subviewAtIndex(views, index): | ||
| return fb.evaluateObjectExpression('[%s objectAtIndex:%i]' % (views, index)) | ||
|
|
||
| def viewsCount(views): | ||
| return int(fb.evaluateExpression('(int)[%s count]' % views)) | ||
|
|
||
| def accessibilityIdentifier(view): | ||
| return fb.evaluateObjectExpression('[%s accessibilityIdentifier]' % view) | ||
|
|
||
| def isEqualToString(identifier, needle): | ||
| return fb.evaluateBooleanExpression('[%s isEqualToString:@"%s"]' % (identifier, needle)) | ||
|
|
||
| def setTextInView(view, text): | ||
| fb.evaluateObjectExpression('[%s setText:@"%s"]' % (view, text)) | ||
| viewHelpers.flushCoreAnimationTransaction() | ||
|
|
||
| def isFirstResponder(view): | ||
| return fb.evaluateBooleanExpression('[%s isFirstResponder]' % view) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My python is clearly lacking, how does this
else:section work? Does it only run if theforloop has nothing to loop over (in this case view count is zero)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's exactly it. My python isn't that great either, only found out about this while writing this code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't handle any first responder that has subviews. Is there a reason for that? I'm not aware of anything that prevents a view with subviews from being first responder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command is intended to be used after selecting a text field/text view, making it first responder, then setting the text on it.
With that in mind, if anything else is first responder at the time this command is run it will either do nothing, or set the text property on it.
I took the happy path for this, but I could put checks in the
setTextInViewfunction which only set text on classes which respond tosetText:.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking back over the code, this branch of code is only executed when a view has no subviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, and I'm wondering about cases where some text input view has internal subviews. There's no guarantee that that a text input view will always have no subviews. I think the
isFirstRespondercheck should go above the loop, and if it fails, then loop over subviews. This would make it breadth first, but I don't see a problem with that, do you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no issue. Pushed it up.