Fixing pa11y and fa11y commands for iOS8.1+ #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands/FBAccessibilityCommands.py
Outdated
Contributor
There was a problem hiding this comment.
Is this a backwards compatible change, will it still work < iOS 8.1?
Contributor
|
Thanks @gkassabli! I have a couple questions. |
Contributor
Author
|
Thanks for good point, @kastiglione. Addressed your comments! |
commands/FBAccessibilityCommands.py
Outdated
Contributor
There was a problem hiding this comment.
- This should use
orinstead of binary|. - Maybe extract into a helper method,
isSimulator? - Is there a reason this isn't using
evaluateObjectExpression?
Contributor
Author
There was a problem hiding this comment.
Will address first 2 comments
3. EvaluateObjectExpression will give us string address, while we need string python representation. expressionValue().GetObjectDescription() seems best way for that
Contributor
|
Thanks @gkassabli. One more comment, but otherwise looks good! |
Contributor
|
Thank you 💎 |
kastiglione
added a commit
that referenced
this pull request
Nov 30, 2015
Fixing pa11y and fa11y commands for iOS8.1+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pa11y and fa11y weren't working since iOS8.1 because of Apple API changes. This fix should work both on newer and older versions