Skip to content

Debug superconsole test failure #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndmitchell wants to merge 2 commits into from
Closed

Debug superconsole test failure #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01dbfb4
Debug superconsole test failure
ndmitchell Sep 5, 2022
93a26a5
Update event_log.rs
ndmitchell Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions buck2_client/src/subscribers/event_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,13 +629,12 @@ impl EventSubscriber for EventLog {

/// Return the place to upload logs, or None to not upload logs at all
pub fn log_upload_url() -> Option<&'static str> {
// @oss-enable: #[cfg(off)]
#[cfg(off)]
if hostcaps::is_prod() {
Some("https://manifold.facebook.net")
} else {
Some("https://manifold.c2p.facebook.net")
}
#[cfg(off)] // @oss-disable
{
#[cfg(fbcode_build)]
compile_error!("this code is not meant to be compiled in fbcode");
Expand Down
1 change: 1 addition & 0 deletions superconsole/src/superconsole.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ impl SuperConsole {
}

fn size(&self) -> anyhow::Result<Dimensions> {
eprint!("{:?} vs {:?}", terminal::size(), self.default_size);
match terminal::size() {
Ok(size) => Ok(size.into()),
Err(e) => match self.default_size {
Expand Down