Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50082445 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50082445 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Summary: i convinced myself that creating a link to the ocaml standard library directory as extracted from `ocamlopt.opt -config` was necessary and that we can't just assume `$OPAM_SWITCH/lib/ocaml` but have failed to prove that to myself today. together with ocaml-scripts issue [#2](facebook/ocaml-scripts#2) and similar past questions from vsiles i'm motivated to attempt to remove it so that we create but one link into .opam. Differential Revision: D50082445
facebook-github-bot
force-pushed
the
export-D50082445
branch
from
63e2435 to
8bda0e4
Compare
Summary: i convinced myself that creating a link to the ocaml standard library directory as extracted from `ocamlopt.opt -config` was necessary and that we can't just assume `$OPAM_SWITCH/lib/ocaml` but have failed to prove that to myself today. together with ocaml-scripts issue [#2](facebook/ocaml-scripts#2) and similar past questions from vsiles i'm motivated to attempt to remove it so that we create but one link into .opam. Differential Revision: D50082445
shayne-fletcher
force-pushed
the
export-D50082445
branch
from
8bda0e4 to
795e382
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50082445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: i convinced myself that creating a link to the ocaml standard library directory as extracted from
ocamlopt.opt -configwas necessary and that we can't just assume$OPAM_SWITCH/lib/ocamlbut have failed to prove that to myself today. together with ocaml-scripts issue #2 and similar past questions from vsiles i'm motivated to attempt to remove it so that we create but one link into .opam.Differential Revision: D50082445