Skip to content

build reqwest#27

Closed
aherrmann wants to merge 1 commit intomainfrom
build-reqwest
Closed

build reqwest#27
aherrmann wants to merge 1 commit intomainfrom
build-reqwest

Conversation

@aherrmann
Copy link
Contributor

@aherrmann aherrmann commented Oct 17, 2022

Add a fixup to build the reqwest crate.

With this patch and #26 applied I am able to build all of //third-party/rust: on Ubuntu 22.04 x86_64 Linux apart from the following which are expected to fail due to platform incompatibility.

  • blake3-0.3.8-simd_neon-aarch64
  • blake3-0.3.8-simd_neon-armv7
  • winreg-0.10.1

```
Stderr: error[E0583]: file not found for module `async_impl`
   --> third-party/rust/vendor/reqwest-0.11.12/src/lib.rs:306:5
    |
306 |     mod async_impl;
    |     ^^^^^^^^^^^^^^^
    |
    = help: to create the module `async_impl`, create file "buck-out/v2/gen/buck/c7e37843b7922818/third-party/rust/__reqwest__/__srcs/vendor/reqwest-0.11.12/src/async_impl.rs" or "buck-out/v2/gen/buck/c7e37843b7922818/third-party/rust/__reqwest__/__srcs/vendor/reqwest-0.11.12/src/async_impl/mod.rs"
```
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2022
@facebook-github-bot
Copy link
Contributor

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@arlyon
Copy link
Contributor

arlyon commented Oct 17, 2022

Approving internally, expected to be merged shortly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants