Skip to content

Convert _static_extension_utils from C++ to Cython #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filbranden wants to merge 1 commit into from
Closed

Convert _static_extension_utils from C++ to Cython #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion prelude/python/python_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,10 @@ def convert_python_library_to_executable(

cxx_executable_srcs = [
CxxSrcWithFlags(file = ctx.attrs.cxx_main, flags = []),
CxxSrcWithFlags(file = ctx.attrs._cxx_static_extension_utils, flags = []),
CxxSrcWithFlags(file = static_extension_info_out, flags = []),
] + [
CxxSrcWithFlags(file = i, flags = [])
for i in ctx.attrs._cxx_static_extension_utils
]
impl_params = CxxRuleConstructorParams(
rule_type = "python_binary",
Expand Down
2 changes: 1 addition & 1 deletion prelude/rules_impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def _python_binary_attrs():
"package_split_dwarf_dwp": attrs.bool(default = False),
"_create_manifest_for_source_dir": _create_manifest_for_source_dir(),
"_cxx_hacks": attrs.dep(default = "prelude//cxx/tools:cxx_hacks"),
"_cxx_static_extension_utils": attrs.option(attrs.source(), default = None),
"_cxx_static_extension_utils": attrs.list(attrs.source(), default = []),
"_cxx_toolchain": _cxx_toolchain(),
"_omnibus_environment": omnibus_environment_attr(),
"_package_remotely": attrs.bool(default = _package_python_binary_remotely()),
Expand Down