docs: Follow sidebar structure more

Summary:
Moves a bunch of the remaining pages to follow the sidebar.

I had to rename `benefits.md` to `compared_to_buck1.md` as otherwise it got picked up as an index page

I tried to enforce this in code but simplifying the configuration of the sidebar even more turns out to be a bit hard, so I'm not doing it

To keep from breaking links, I've added redirects. Those are documented as not being testable in dev builds, but I can see them in the build output so probably they're working fine

Reviewed By: iguridi

Differential Revision: D60024231

fbshipit-source-id: b93c8f67668ad6d68e3ddb9c3c7eb749435bed64

docs/benefits.md → docs/about/benefits/compared_to_buck1.md

@@ -1,5 +1,5 @@
 ---
-id: benefits
+id: compared_to_buck1
 title: Benefits When Compared to Buck1
 ---
 

docs/why.md → docs/about/why.md

@@ -70,28 +70,28 @@ different from Bazel).
   having all the rules external to the binary, the most important and complex
   rule (such as in C++), don't have access to magic internal features. As a
   result, features have been made available to all rules, including:
-  - [Dep files](rule_authors/dep_files.md) - the ability to declare that a
+  - [Dep files](../rule_authors/dep_files.md) - the ability to declare that a
     subset of the files weren't actually used, and thus not be sensitive to
     changes within them.
-  - [Incremental actions](rule_authors/incremental_actions.md) - the ability to
-    have the action short-circuit some subset of the work if run again.
+  - [Incremental actions](../rule_authors/incremental_actions.md) - the ability
+    to have the action short-circuit some subset of the work if run again.
 - **Buck2 uses a dynamic (aka monadic) graph as its underlying computation
   engine** - while most dependencies are specified statically, there are two
   particular features that expose dynamic power to rule authors:
-  - [Dynamic dependencies](rule_authors/dynamic_dependencies.md) - enable rules
-    to build a file then look at its contents before specifying the dependencies
-    and steps in future actions. Common uses are languages where the dependency
-    structure within a project must follow imports (e.g. Haskell, OCaml) and
-    distributed ThinLTO (where the best optimization plan is generated from
-    summaries).
-  - [Anonymous targets](rule_authors/anon_targets.md) - enable rules to create a
-    graph that has more sharing than the original user graph. As a result, two
-    unrelated binaries can compile shared code only once, despite the shared
-    code not knowing about this commonality. This feature is useful for rules
-    like Swift feature resolution.
-- **[Transitive-sets](rule_authors/transitive_sets.md)** - similar in purpose to
-  Bazel's [depset](https://bazel.build/rules/lib/depset). But, instead of being
-  just a memory optimization, are also wired into the dependency graph,
+  - [Dynamic dependencies](../rule_authors/dynamic_dependencies.md) - enable
+    rules to build a file then look at its contents before specifying the
+    dependencies and steps in future actions. Common uses are languages where
+    the dependency structure within a project must follow imports (e.g. Haskell,
+    OCaml) and distributed ThinLTO (where the best optimization plan is
+    generated from summaries).
+  - [Anonymous targets](../rule_authors/anon_targets.md) - enable rules to
+    create a graph that has more sharing than the original user graph. As a
+    result, two unrelated binaries can compile shared code only once, despite
+    the shared code not knowing about this commonality. This feature is useful
+    for rules like Swift feature resolution.
+- **[Transitive-sets](../rule_authors/transitive_sets.md)** - similar in purpose
+  to Bazel's [depset](https://bazel.build/rules/lib/depset). But, instead of
+  being just a memory optimization, are also wired into the dependency graph,
   providing a reduction in the size of the dependency graph.
 - **Buck2 is not phased** - there are no target graph/action graph phases, just
   a series of dependencies in a
@@ -115,7 +115,7 @@ different from Bazel).
   builds 2x as fast as Buck1.
 
 For a comprehensive list of benefits, see
-[Benefits Compared to Buck1](benefits.md).
+[Benefits Compared to Buck1](benefits/compared_to_buck1.md).
 
 ## Why use Buck2?
 

docs/index.md

@@ -31,8 +31,9 @@ your team.
 
 ### For end users
 
-- [Getting Started](getting_started.md) - how to get started with using Buck2.
-- [Benefits](benefits.md) - the benefits of using Buck2.
+- [Getting Started](about/getting_started.md) - how to get started with using
+  Buck2.
+- [Benefits](about/benefits/compared_to_buck1.md) - the benefits of using Buck2.
 
 <FbInternalOnly>
 

website/docusaurus.config.js

@@ -63,6 +63,39 @@ const { fbContent, isInternal } = require('docusaurus-plugin-internaldocs-fb/int
         anonymizeIP: true,
       },
     ],
+    [
+      '@docusaurus/plugin-client-redirects',
+      {
+        redirects: [
+          {
+            to: '/docs/about/why',
+            from: '/docs/why',
+          },
+          {
+            to: '/docs/about/getting_started',
+            from: '/docs/getting_started',
+          },
+          {
+            to: '/docs/about/benefits/compared_to_buck1',
+            from: '/docs/benefits',
+          },
+          {
+            to: '/docs/about/bootstrapping',
+            from: '/docs/bootstrapping',
+          },
+        ] + (!isInternal()) ? [] : [
+          // Internal-only redirects
+          {
+            to: '/docs/about/benefits/testimonials',
+            from: '/docs/testimonials',
+          },
+          {
+            to: '/docs/about/knowledge_sharing',
+            from: '/docs/knowledge_sharing',
+          },
+        ],
+      },
+    ],
   ],
 
   themeConfig:

website/sidebars.js

@@ -39,19 +39,19 @@ const manualSidebar = [
     type: 'category',
     label: 'About Buck2',
     items: [
-      'why',
+      'about/why',
       // The getting_started page is for OSS only.
-      isInternal() ? [] : 'getting_started',
+      isInternal() ? [] : 'about/getting_started',
       {
         type: 'category',
         label: 'Benefits',
         items: [
-          'benefits',
-          isInternal() ? 'testimonials' : [],
+          'about/benefits/compared_to_buck1',
+          isInternal() ? 'about/benefits/testimonials' : [],
         ],
       },
-      isInternal() ? 'knowledge_sharing' : [],
-      'bootstrapping',
+      isInternal() ? 'about/knowledge_sharing' : [],
+      'about/bootstrapping',
     ],
   },
   {

website/src/pages/index.js

@@ -30,7 +30,7 @@ function HomepageHeader() {
           <div className={styles.buttons}>
             <Link
               className="button button--secondary button--lg"
-              to="/docs/benefits">
+              to="/docs/about/benefits/compared_to_buck1">
               Why switch?
             </Link>
             <Link
@@ -44,12 +44,12 @@ function HomepageHeader() {
           <div className={styles.buttons}>
             <Link
               className="button button--secondary button--lg"
-              to="/docs/why">
+              to="/docs/about/why">
               Why Buck2?
             </Link>
             <Link
               className="button button--secondary button--lg"
-              to="/docs/getting_started">
+              to="/docs/about/getting_started">
               Getting started
             </Link>
           </div>