Skip to content

Commit

Permalink
Fixed some copy-pasta naming in file watcher tests
Browse files Browse the repository at this point in the history
Summary:
# Context

We are introducing EdenFS notifications to support scalable and ergonomic file system notifications for EdenFS mounts.

# This Diff

* Some names were janky - fixed

# Next Steps

* New tests commit transitions
* Fix bug in EdenFS that causes `to` and `from` to be switched in commit transitions.
* After fix deployed - remove work around in edenfs file watcher.

Reviewed By: blackm00n

Differential Revision: D67584507

fbshipit-source-id: 5fd244e13d7e07d23740fc6b1f114e253013f6f4
  • Loading branch information
jdelliot authored and facebook-github-bot committed Dec 23, 2024
1 parent 1fbe41c commit ae9ece5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions tests/core/io/test_edenfs.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,57 +27,57 @@


@buck_test(setup_eden=True)
async def test_edenfs_create_file_eden(buck: Buck) -> None:
async def test_edenfs_create_file(buck: Buck) -> None:
await run_create_file_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_modify_file_eden(buck: Buck) -> None:
async def test_edenfs_modify_file(buck: Buck) -> None:
await run_modify_file_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_remove_file_eden(buck: Buck) -> None:
async def test_edenfs_remove_file(buck: Buck) -> None:
await run_remove_file_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_rename_file_eden(buck: Buck) -> None:
async def test_edenfs_rename_file(buck: Buck) -> None:
await run_rename_file_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


# File replace is not supported on Windows
@buck_test(setup_eden=True, skip_for_os=["windows"])
async def test_edenfs_replace_file_eden(buck: Buck) -> None:
async def test_edenfs_replace_file(buck: Buck) -> None:
await run_replace_file_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_create_directory_eden(buck: Buck) -> None:
async def test_edenfs_create_directory(buck: Buck) -> None:
await run_create_directory_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_remove_directory_eden(buck: Buck) -> None:
async def test_edenfs_remove_directory(buck: Buck) -> None:
await run_remove_directory_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)


@buck_test(setup_eden=True)
async def test_edenfs_rename_directory_eden(buck: Buck) -> None:
async def test_edenfs_rename_directory(buck: Buck) -> None:
await run_rename_directory_test(
buck, FileSystemType.EDEN_FS, FileWatcherProvider.EDEN_FS
)
2 changes: 1 addition & 1 deletion tests/core/io/test_fs_hash_crawler.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async def test_fs_hash_cralwer_remove_directory(buck: Buck) -> None:


@buck_test(setup_eden=False)
async def test_edenfs_rename_directory(buck: Buck) -> None:
async def test_fs_hash_cralwer_rename_directory(buck: Buck) -> None:
await run_rename_directory_test(
buck, FileSystemType.NATIVE, FileWatcherProvider.FS_HASH_CRAWLER
)
2 changes: 1 addition & 1 deletion tests/core/io/test_notify.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async def test_notify_remove_directory(buck: Buck) -> None:


@buck_test(setup_eden=False)
async def test_edenfs_rename_directory(buck: Buck) -> None:
async def test_notify_rename_directory(buck: Buck) -> None:
await run_rename_directory_test(
buck, FileSystemType.NATIVE, FileWatcherProvider.RUST_NOTIFY
)

0 comments on commit ae9ece5

Please sign in to comment.