Closed
Conversation
As pointed out in facebook/buck2#116, it could be helpful to pinpoint a specific version of clang. This is an attempt to expose two more parameters: 1. `compiler` which defaults to `clang` 2. `cxx_compiler` which defaults to `clang++`
facebook-github-bot
added
the
CLA Signed
Contributor
|
@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Apr 12, 2023
Summary: As pointed out in facebook/buck2#116, it could be helpful to pinpoint a specific version of clang. This is an attempt to expose two more parameters: 1. `compiler` which defaults to `clang` 2. `cxx_compiler` which defaults to `clang++` X-link: facebook/buck2-prelude#7 Reviewed By: krallin Differential Revision: D44871158 Pulled By: ndmitchell fbshipit-source-id: 43e96250e1c704ac0c6fbe0dcb1ff7398f5c6a5b
Contributor
|
@ndmitchell merged this pull request in 4fca09a. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Apr 12, 2023
Summary: As pointed out in #116, it could be helpful to pinpoint a specific version of clang. This is an attempt to expose two more parameters: 1. `compiler` which defaults to `clang` 2. `cxx_compiler` which defaults to `clang++` X-link: facebook/buck2-prelude#7 Reviewed By: krallin Differential Revision: D44871158 Pulled By: ndmitchell fbshipit-source-id: 43e96250e1c704ac0c6fbe0dcb1ff7398f5c6a5b
Contributor
|
Thanks for the contribution! |
avdv
added a commit
to avdv/buck2-prelude
that referenced
this pull request
Aug 25, 2025
…dden-input Add hidden inputs to final ghci script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in facebook/buck2#116, it could be helpful to pinpoint a specific version of clang. This is an attempt to expose two more parameters:
compilerwhich defaults toclangcxx_compilerwhich defaults toclang++