Kerb Validator #1583
Merged
Kerb Validator #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerwuster
force-pushed
the
kerb_validation
branch
from
146f313
to
4fbd56e
Compare
|
When warnings are opened up, do you think there could be value in numbering each warning and having a corresponding yellow circle with a number surrounding the feature? You currently have to click through to reveal which warning corresponds to the feature. |
bhousel
approved these changes
Oct 26, 2024
…eing changed to the kerb tag
…s will help determine kerb type
…ay as it cannot happen. and a few other updates
tannerwuster
force-pushed
the
kerb_validation
branch
from
5dbff8b
to
f86da2a
Compare
- added more tests
|
Looks good, lets merge it and then people can try it out in canary! 🐤 |
|
Nice work @tannerwuster! Looking great in Canary so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag any crossings without kerb nodes with a new validator.
The validator will give the user a button to 'fix' by adding kerb nodes 1m from the endpoints of the crossing. (It will be up to the user to position the kerb nodes.)
Offer different fixes in the validation pane
Flush
Lowered
Raised
closes #1460