Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain multi-selection when SHIFT key is held down #1440

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

tannerwuster
Copy link
Contributor

@tannerwuster tannerwuster commented May 16, 2024

Fixes #1071 and Fixes #1137 which are issues with the multi-selection. Previously, if a user was holding down the SHIFT key to select multiple entity and clicked on an area without an entity, all selected entities would be deselected, even though the SHIFT key was still being held down.

With this fix, the selected entities will remain selected as long as the SHIFT key is held down, regardless of where the user clicks.

  1. Before
before.mov
  1. After
after.mov

@bhousel
Copy link
Contributor

bhousel commented May 20, 2024

Seems simple enough - good find! 👍

@bhousel bhousel merged commit c480b42 into main May 20, 2024
4 checks passed
@bhousel bhousel added this to the v2.3.2 milestone May 20, 2024
@tannerwuster tannerwuster deleted the multi_select_fix branch May 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants