Fixes command mode for fish #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not running appendAliasExpand when fish is set as shell.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
| @@ -170,7 +170,9 @@ def appendAliasExpansion(): | |||
| # despite documentation hinting otherwise. | |||
| # | |||
| # so here we must ask bash to turn on alias expansion. | |||
| appendToFile(""" | |||
| shell = os.environ.get('SHELL') | |||
| if 'fish' not in shell: | |||
There was a problem hiding this comment.
couldhave just done if fish in shell: return but nbd
There was a problem hiding this comment.
Good to know for next time!
|
Thanks for the fix!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not running appendAliasExpand when fish is set as shell.
See #226 for more details.