Fix issue with long screens #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My screen had more rows than the size of `lbls` so when I chose quick select on a full list of candidates, I got a traceback "IndexError: string index out of range." This only displays labels up to the number of labels and no more.
|
Thanks @slackorama so much for putting up the PR for this! logic seems good -- its too bad we don't have test coverage for this though. I'll try to add something after this lands. Also I should make a new release since this and a few other fixes have gone in recently... lemme file a task on myself to do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My screen had more rows than the size of
lblsso when I chose quickselect on a full list of candidates, I got a traceback "IndexError:
string index out of range."
This only displays labels up to the number of labels and no more.