cpe_chrome does not require dependency on fb_osquery

[johnnyramos]

Seems a dependency was added in this commit but I don't see the requirement for it in the code.

Line:

IT-CPE/itchef/cookbooks/cpe_chrome/metadata.rb

Line 13 in 91a35df

depends 'fb_osquery'

[ChefAustin]

Furthermore, (even if the dependency were necessary) fb_osquery is not offered in either this repo or facebook/chef-cookbooks.

[steelcowboy]

Sorry about this oversight, unfortunately it is actually required: node.installed? comes from fb_osquery:

IT-CPE/itchef/cookbooks/cpe_chrome/resources/cpe_chrome_win.rb

Line 30 in d001ffc

return unless chrome_installed || node.installed?('Google Chrome')

fb_osquery was intended to be open-sourced, I will see if there are any blockers to doing that and update this issue once it is done

[erikng]

I'm sure you're unlikely to use our cookbook but we've had a API style osquery cookbook open sourced for about a year.

https://github.com/uber/client-platform-engineering/tree/main/chef/cookbooks/cpe_osquery

[johnnyramos]

Just following up @steelcowboy - thanks!

[steelcowboy]

Sorry it took me a while to follow up on this! I'm in the process of open sourcing fb_osquery and I expect I'll have it done in the next few days