Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd run override #691

Closed
wants to merge 4 commits into from
Closed

Readd run override #691

wants to merge 4 commits into from

Conversation

danielcohenlive
Copy link

@danielcohenlive danielcohenlive commented Sep 9, 2021

in order to support python 3.7, which has no unittest.TestCase._callSetUp() or unittest.TestCase._callTearDown() method, we add and remove alarms in the override of unittest.TestCase.run()

Daniel Cohen added 2 commits September 9, 2021 11:20
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #691 (1306e13) into main (9afd770) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files         350      350           
  Lines       29576    29576           
=======================================
  Hits        27529    27529           
  Misses       2047     2047           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afd770...1306e13. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@danielcohenlive has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@danielcohenlive merged this pull request in fb5a764.

@saitcakmak saitcakmak deleted the readd-run-override branch August 25, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants