Pin BoTorch to 0.4.0 #507
Closed
Pin BoTorch to 0.4.0 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As discussed with Balandat offline yesterday, we should pin BoTorch versions so that we don't always have to release Ax right after BoTorch. Right now, we're in a slightly dangerous state where BoTorch 0.4.0 is released, and so because our setup.py file runs `pip install botorch>=0.3.3`, pip will install 0.4.0 now. But the stable version of Ax is actually not compatible with this newest version of BoTorch (as you can see from the failure of this test: https://github.com/facebook/Ax/runs/1967381927?check_suite_focus=true). Differential Revision: D26635518 fbshipit-source-id: 8796710361323d58ff9ffe80125eb8ca391a5506
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26635518 |
|
This pull request has been merged in c428eb1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As discussed with Balandat offline yesterday, we should pin BoTorch versions so that we don't always have to release Ax right after BoTorch.
Right now, we're in a slightly dangerous state where BoTorch 0.4.0 is released, and so because our setup.py file runs
pip install botorch>=0.3.3, pip will install 0.4.0 now. But the stable version of Ax is actually not compatible with this newest version of BoTorch (as you can see from the failure of this test: https://github.com/facebook/Ax/runs/1967381927?check_suite_focus=true).Differential Revision: D26635518