9/n: Temporarily clone generator runs in generation strategy to ensure 1:1 relationship to SQL #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24786849 |
added 7 commits
November 6, 2020 09:30
Differential Revision: D24601191 fbshipit-source-id: c7a8beb2c0c6c466607b9e882a1aa05206603ffb
Differential Revision: D24749685 fbshipit-source-id: a638c04b67cc0c3e2c20c4467470a6e1395e6afd
…pon re-creation Differential Revision: D24601249 fbshipit-source-id: b29ff8618a44d4a116e7727336198935fe666df4
Differential Revision: D24601318 fbshipit-source-id: c055c9a7c2dabeb38627b49940b7ccbf61650bfa
Differential Revision: D24759873 fbshipit-source-id: a265e322b6aba6eecf852450004156c645c26de0
Differential Revision: D24764391 fbshipit-source-id: ece92d458c0facb1b98734ae260c346cdd15b675
…e 1:1 relationship to SQL (facebook#422) Summary: Pull Request resolved: facebook#422 To get in the stack of diffs that takes care of setting db_ids on all user-facing Ax objects that have a corresponding SQA object in DB, we temporarily clone generator runs before returning them from generation strategy, to avoid pointing one user-facing instance to two separate SQA objects. This will no longer be necessary after the next phase of the storage & perf project, taskified in T79183560 Differential Revision: D24786849 fbshipit-source-id: 4f101529461a9354d7301ce7dd63d908652031b8
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Nov 6, 2020
…e 1:1 relationship to SQL (facebook#422) Summary: Pull Request resolved: facebook#422 To get in the stack of diffs that takes care of setting db_ids on all user-facing Ax objects that have a corresponding SQA object in DB, we temporarily clone generator runs before returning them from generation strategy, to avoid pointing one user-facing instance to two separate SQA objects. This will no longer be necessary after the next phase of the storage & perf project, taskified in T79183560 Differential Revision: D24786849 fbshipit-source-id: d61d5e8281e9a8bbf270d9d1359774256ce599a8
lena-kashtelyan
force-pushed
the
export-D24786849
branch
from
73b5ab4 to
c5a093d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D24786849 |
lena-kashtelyan
force-pushed
the
export-D24786849
branch
from
c5a093d to
8843dd4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D24786849 |
|
This pull request has been merged in d5b7de1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To get in the stack of diffs that takes care of setting db_ids on all user-facing Ax objects that have a corresponding SQA object in DB, we temporarily clone generator runs before returning them from generation strategy, to avoid pointing one user-facing instance to two separate SQA objects. This will no longer be necessary after the next phase of the storage & perf project, taskified in T79183560
Differential Revision: D24786849