Update GenerationNode repr w/ brief node and model spec strings #3319
+63
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69260519 |
mgrange1998
added a commit
to mgrange1998/Ax
that referenced
this pull request
Feb 6, 2025
…book#3319) Summary: 1. Adjust GenNode.repr to only print `TransitionCriterionClass(transition_to=<transition_to>)` (can use tc.class.name for this), omitting other TransitionCriteria settings 2. Adds a brief repr of ModelSpec repr to ignore its kwargs 3. Reorders Generation Node args to node_name first, Model Specs after, then transition criteria last. 4. Adds ' tick marks to "node_name" arg 5. Update the corresponding unit tests Note: Added a specific brief repr method to GenerationNode instead of changing TransitionCriteria's repr, Additionally, added brief repr for model spec following prior feedback. Differential Revision: D69260519
mgrange1998
force-pushed
the
export-D69260519
branch
from
d1b23a3 to
119d7bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69260519 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3319 +/- ##
==========================================
- Coverage 95.70% 95.70% -0.01%
==========================================
Files 532 532
Lines 52450 52467 +17
==========================================
+ Hits 50196 50212 +16
- Misses 2254 2255 +1 ☔ View full report in Codecov by Sentry. |
…book#3319) Summary: 1. Adjust GenNode.repr to only print `TransitionCriterionClass(transition_to=<transition_to>)` (can use tc.class.name for this), omitting other TransitionCriteria settings 2. Adds a brief repr of ModelSpec repr to ignore its kwargs 3. Reorders Generation Node args to node_name first, Model Specs after, then transition criteria last. 4. Adds ' tick marks to "node_name" arg 5. Update the corresponding unit tests Note: Added a specific brief repr method to GenerationNode instead of changing TransitionCriteria's repr, Additionally, added brief repr for model spec following prior feedback. Reviewed By: mgarrard, lena-kashtelyan Differential Revision: D69260519
mgrange1998
force-pushed
the
export-D69260519
branch
from
119d7bf to
6bcf910
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69260519 |
|
This pull request has been merged in 1a3715b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adjust GenNode.repr to only print
TransitionCriterionClass(transition_to=<transition_to>)(can use tc.class.name for this), omitting other TransitionCriteria settingsAdds a brief repr of ModelSpec repr to ignore its kwargs
Reorders Generation Node args to node_name first, Model Specs after, then transition criteria last.
Adds ' tick marks to "node_name" arg
Update the corresponding unit tests
Note: Added a specific brief repr method to GenerationNode instead of changing TransitionCriteria's repr,
Additionally, added brief repr for model spec following prior feedback.
Differential Revision: D69260519