fix MBM model selection CV bug with uncertainty-based diagnostics #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69259144 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 533 533
Lines 52516 52525 +9
=======================================
+ Hits 50282 50291 +9
Misses 2234 2234 ☔ View full report in Codecov by Sentry. |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 7, 2025
…cebook#3318) Summary: Fixes a bug for model selection criteria that rely on model uncertainty. Previously we passed variance instead of standard deviation. Reviewed By: saitcakmak Differential Revision: D69259144
sdaulton
force-pushed
the
export-D69259144
branch
from
cb130e2 to
078c43a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69259144 |
…cebook#3317) Summary: see title. This enables not warm-starting, which can be desirable for evaluating over-parameterized models via CV. Reviewed By: saitcakmak Differential Revision: D68114572
…cebook#3318) Summary: Fixes a bug for model selection criteria that rely on model uncertainty. Previously we passed variance instead of standard deviation. Reviewed By: saitcakmak Differential Revision: D69259144
sdaulton
force-pushed
the
export-D69259144
branch
from
078c43a to
2a5637b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69259144 |
|
This pull request has been merged in 50c83be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes a bug for model selection criteria that rely on model uncertainty. Previously we passed variance instead of standard deviation.
Differential Revision: D69259144