fix EBTS bug where gen returned less than n total weight #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 6, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) Reviewed By: danielcohenlive Differential Revision: D69253157
sdaulton
force-pushed
the
export-D69253157
branch
from
0e47785 to
0e13fb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3316 +/- ##
==========================================
- Coverage 95.74% 95.70% -0.05%
==========================================
Files 533 533
Lines 52516 52537 +21
==========================================
- Hits 50280 50278 -2
- Misses 2236 2259 +23 ☔ View full report in Codecov by Sentry. |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 6, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Differential Revision: D69253157
sdaulton
force-pushed
the
export-D69253157
branch
from
0e13fb3 to
68a2f1e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 7, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Differential Revision: D69253157
sdaulton
force-pushed
the
export-D69253157
branch
from
68a2f1e to
632333f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 7, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Reviewed By: mgarrard Differential Revision: D69253157
sdaulton
force-pushed
the
export-D69253157
branch
from
632333f to
d51fc7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
sdaulton
force-pushed
the
export-D69253157
branch
from
d51fc7e to
2702216
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 10, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Reviewed By: mgarrard, esantorella Differential Revision: D69253157
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
sdaulton
force-pushed
the
export-D69253157
branch
from
2702216 to
416df5c
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Feb 10, 2025
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Reviewed By: mgarrard, esantorella Differential Revision: D69253157
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
Summary: This could happen if enought `weights` were zero here than the length of `weights` became less than `n`: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113. The `AlmostEqual` is needed to deal with numerical precision (e.g. 9.0000000002) This also makes `batch_size` optional in `BenchmarkMethod`. A `batch_size` of `None`, means the batch size from the initial trial is used. For bandits, this means the cardinality of the search space becomes the batch size after the factorial node. Reviewed By: mgarrard, esantorella Differential Revision: D69253157
sdaulton
force-pushed
the
export-D69253157
branch
from
416df5c to
292917d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69253157 |
|
This pull request has been merged in 0809eb3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This could happen if enought
weightswere zero here than the length ofweightsbecame less thann: https://www.internalfb.com/code/fbsource/[b9c286a9f21709eb4c964c3c24bb629b2b218c86]/fbcode/ax/models/discrete/thompson.py?lines=109-113.The
AlmostEqualis needed to deal with numerical precision (e.g. 9.0000000002)Reviewed By: danielcohenlive
Differential Revision: D69253157