Adding fit_only_completed_map_metrics option to Adaptor
#3312
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69213286 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 6, 2025
SebastianAment
force-pushed
the
export-D69213286
branch
from
ec9e5e4 to
1a4fb07
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 6, 2025
|
This pull request was exported from Phabricator. Differential Revision: D69213286 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 533 533
Lines 52537 52553 +16
=======================================
+ Hits 50278 50294 +16
Misses 2259 2259 ☔ View full report in Codecov by Sentry. |
SebastianAment
force-pushed
the
export-D69213286
branch
from
1a4fb07 to
8d906e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69213286 |
|
This pull request has been merged in e10b4a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit introduces the option to fit to data from uncompleted map metrics with the base
Adaptor.Differential Revision: D69213286