Migrate GS usages to new module location #3311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 5, 2025
Summary: X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 5, 2025
Summary: Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Differential Revision: D68645075
ItsMrLin
force-pushed
the
export-D68645075
branch
from
f9d21f5 to
028a35d
Compare
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 5, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 5, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
force-pushed
the
export-D68645075
branch
from
028a35d to
cdde13a
Compare
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
force-pushed
the
export-D68645075
branch
from
cdde13a to
c82eb07
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 6, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
force-pushed
the
export-D68645075
branch
from
c82eb07 to
f58e30c
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 6, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
force-pushed
the
export-D68645075
branch
from
f58e30c to
906b6c1
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 6, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 6, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
force-pushed
the
export-D68645075
branch
from
906b6c1 to
d420e55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
force-pushed
the
export-D68645075
branch
from
d420e55 to
5514b09
Compare
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Feb 7, 2025
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 7, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
Summary: X-link: facebookresearch/aepsych#623 Pull Request resolved: facebook#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
|
This pull request was exported from Phabricator. Differential Revision: D68645075 |
ItsMrLin
force-pushed
the
export-D68645075
branch
from
5514b09 to
8529f13
Compare
ItsMrLin
added a commit
to ItsMrLin/aepsych
that referenced
this pull request
Feb 7, 2025
Summary: Pull Request resolved: facebookresearch#623 X-link: facebook/Ax#3311 Removing the following old files from `ax/modelbridge/` in favor of the new `ax/generation_strategy` directory. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Reviewed By: saitcakmak Differential Revision: D68645075
facebook-github-bot
pushed a commit
to facebookresearch/Kats
that referenced
this pull request
Feb 7, 2025
Summary: X-link: facebookresearch/aepsych#623 X-link: facebook/Ax#3311 In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder. Reviewed By: saitcakmak Differential Revision: D68645075 fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
facebook-github-bot
pushed a commit
to facebookresearch/aepsych
that referenced
this pull request
Feb 7, 2025
Summary: Pull Request resolved: #623 X-link: facebook/Ax#3311 In this diff, we migrated everything in the codebase to use `ax.generation_strategy.xxx` instead of the old `ax.modelbridge.xxx` for the following files. ``` best_model_selector.py dispatch_utils.py external_generation_node.py generation_node_input_constructors.py generation_node.py generation_strategy.py model_spec.py transition_criterion.py ``` Meta: In the previous diff D68720587 we moved these files from `ax/modelbridge/` to the new `ax/generation_strategy` directory, but all applications are still using/importing from the `modelbridge` folder. Reviewed By: saitcakmak Differential Revision: D68645075 fbshipit-source-id: e724c73e3733a04d6c5e8fa31284473095451e75
|
This pull request has been merged in 29ab9e0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removing the following old files from
ax/modelbridge/in favor of the newax/generation_strategydirectory.Differential Revision: D68645075