[GHA] Upload an artifact of the converted tutorials for testing #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3303 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 533 533
Lines 52516 52516
=======================================
Hits 50282 50282
Misses 2234 2234 ☔ View full report in Codecov by Sentry. |
Debugging why the website build step is failing. Also list all the node packages installed
This reverts commit 84b741f.
Debugging why the website build step is failing. Also list all the node packages installed
We want the entire website directory in addition to the built docs
This allows Yarn to install the same exact dependency tree across all machines.
The workflow checks out the `docusaurus-versions` branch, we need to merge in the changes from this branch to actually debug yarn and docusaurus
CristianLara
added a commit
that referenced
this pull request
Feb 7, 2025
I previously added this to resolve issues with building when we have many versions of our docs. While this works locally we've been seeing failures to build in GHA. Some debugging pointed to this being the issue, so let's disable for now. The Docusaurus team is actively working on speeding up build time and plans to roll out these optimizations as they become more stable. I tested this by adding a test workflow to build the website using these changes in a separate PR for debugging - PR: #3303 - Successful workflow run: https://github.com/facebook/Ax/actions/runs/13206354540/job/36870297699 See this commit for when I added these options: CristianLara@d04a3b2 See Docusaurus's "faster" initiative: facebook/docusaurus#10556
|
This PR was only intended for debugging the GHA workflows. Closing this in favor of #3328 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Summary: I previously added this to resolve issues with building when we have many versions of our docs. While this works locally we've been seeing [failures to build in GHA](https://github.com/facebook/Ax/actions/runs/13164146992/job/36740052914). Some debugging pointed to this being the issue, so let's disable for now. The Docusaurus team is actively working on speeding up build time and plans to roll out these optimizations as they become more stable. I tested this by adding a test workflow to build the website using these changes in a separate PR for debugging - PR: #3303 - Successful workflow run: https://github.com/facebook/Ax/actions/runs/13206354540/job/36870297699 See this commit for when I added these options: CristianLara@d04a3b2 See Docusaurus's "faster" initiative: facebook/docusaurus#10556 Pull Request resolved: #3328 Reviewed By: saitcakmak Differential Revision: D69320211 Pulled By: CristianLara fbshipit-source-id: ce72b3c389dd8694746fbdc106c1f1e43c7c1ca3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.