Delete checked_cast and replace `checked_cast_(list|dict|to_tuple|optional)
#3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
==========================================
- Coverage 95.88% 95.87% -0.01%
==========================================
Files 513 513
Lines 51710 51650 -60
==========================================
- Hits 49580 49522 -58
+ Misses 2130 2128 -2 ☔ View full report in Codecov by Sentry. |
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 13, 2025
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
eonofrey
force-pushed
the
export-D67993468
branch
from
e6b6fd4 to
59f3bb5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 14, 2025
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
eonofrey
force-pushed
the
export-D67993468
branch
from
59f3bb5 to
a9abe97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 14, 2025
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
eonofrey
force-pushed
the
export-D67993468
branch
from
a9abe97 to
4044522
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
eonofrey
force-pushed
the
export-D67993468
branch
from
4044522 to
86bad52
Compare
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 15, 2025
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
Summary: Replace `checked_cast` with pyre_extensions `assert_is_instance` Differential Revision: D67879879
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
eonofrey
force-pushed
the
export-D67993468
branch
from
86bad52 to
2872f67
Compare
eonofrey
added a commit
to eonofrey/Ax
that referenced
this pull request
Jan 15, 2025
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
…ptional) (facebook#3230) Summary: Pull Request resolved: facebook#3230 Make the below replacements: `checked_cast_list` -> `assert_is_instance_list` `checked_cast_dict` -> `assert_is_instance_dict` `checked_cast_to_tuple` -> `assert_is_instance_of_tuple` `checked_cast_optional` -> `assert_is_instance_optional` `_argparse_type_encoder` untouched Differential Revision: D67993468
eonofrey
force-pushed
the
export-D67993468
branch
from
2872f67 to
674ccff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67993468 |
|
This pull request has been merged in 3c68bd3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Make the below replacements:
checked_cast_list->assert_is_instance_listchecked_cast_dict->assert_is_instance_dictchecked_cast_to_tuple->assert_is_instance_of_tuplechecked_cast_optional->assert_is_instance_optional_argparse_type_encoderuntouchedDifferential Revision: D67993468