Relax type hints on compute() #2662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61339432 |
|
This pull request was exported from Phabricator. Differential Revision: D61339432 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Aug 15, 2024
Summary: Pull Request resolved: facebook#2662 Scheduler does not have a GenerationStrategy, it has a GenerationStrategyInterface. Relaxing this type hint is important for creating Scheduler.compute_analyses(...) Differential Revision: D61339432
mpolson64
force-pushed
the
export-D61339432
branch
from
9a8667d to
c141188
Compare
Summary: Add compute_result and a new __str__ method to Analysis. The former is useful for computing many analysis at once and handling the exceptions post-compute (as we intend to do on the Scheduler) and the __str__ method is just useful for generating messages in the ExceptionE Differential Revision: D61337928
Summary: Pull Request resolved: facebook#2662 Scheduler does not have a GenerationStrategy, it has a GenerationStrategyInterface. Relaxing this type hint is important for creating Scheduler.compute_analyses(...) Reviewed By: Cesar-Cardoso Differential Revision: D61339432
|
This pull request was exported from Phabricator. Differential Revision: D61339432 |
mpolson64
force-pushed
the
export-D61339432
branch
from
c141188 to
52959da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
- Coverage 95.29% 95.26% -0.03%
==========================================
Files 495 495
Lines 47773 47802 +29
==========================================
+ Hits 45523 45540 +17
- Misses 2250 2262 +12 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in b59af0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Scheduler does not have a GenerationStrategy, it has a GenerationStrategyInterface. Relaxing this type hint is important for creating Scheduler.compute_analyses(...)
Differential Revision: D61339432