Storage support for RBFKernel & LogNormalPrior #2616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds storage support for these components that'll soon be used by default. The storage support is only relevant in cases where they are manually specified. I also removed `REVERSE_GPYTORCH_COMPONENT_REGISTRY` since I did not find it to affect anything. We need `GPYTORCH_COMPONENT_REGISTRY` but the reverse does not seem to do much. Reviewed By: mpolson64 Differential Revision: D60458209
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60458209 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 492 492
Lines 47642 47651 +9
=======================================
+ Hits 45358 45367 +9
Misses 2284 2284 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in c0fa168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds storage support for these components that'll soon be used by default. The storage support is only relevant in cases where they are manually specified.
I also removed
REVERSE_GPYTORCH_COMPONENT_REGISTRYsince I did not find it to affect anything. We needGPYTORCH_COMPONENT_REGISTRYbut the reverse does not seem to do much.Reviewed By: mpolson64
Differential Revision: D60458209