Expand trials_as_df to support multiple GenerationNodes in a single trial #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial Summary: This diff fixes a few things: (1) Recently we expanded generation strategy to be able to support generation from multiple generation nodes for a single batch trial. However trials as df wouldn't reflect that multiple nodes or models was used for a specific trial. This diff fixes that by changes the values of the Step/Node and Model(s) column from single strs to list of strings (2) Previously manual trials were being forgotten as they were not associated with a node, so the df was returning none. Now we return a row for manually added trials with Step/Node and Models == Manual. (Or manual would be in the list if multple nodes were used) Differential Revision: D59738292
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59738292 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 95.23% 95.23% -0.01%
==========================================
Files 489 489
Lines 47664 47643 -21
==========================================
- Hits 45392 45371 -21
Misses 2272 2272 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in aeb8d79. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff fixes a few things:
(1) Recently we expanded generation strategy to be able to support generation from multiple generation nodes for a single batch trial. However trials as df wouldn't reflect that multiple nodes or models was used for a specific trial. This diff fixes that by changes the values of the Step/Node and Model(s) column from single strs to list of strings
(2) Previously manual trials were being forgotten as they were not associated with a node, so the df was returning none. Now we return a row for manually added trials with Step/Node and Models == Manual. (Or manual would be in the list if multple nodes were used)
Differential Revision: D59738292