Update GenerationNode.model_to_gen_from_name #2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 497 497
Lines 48501 48507 +6
=======================================
+ Hits 46227 46233 +6
Misses 2274 2274 ☔ View full report in Codecov by Sentry. |
Summary: The current setup uses `node.model_spec_to_gen_from.model_key` to get the default name for a given node, which will attempt to fit models for GenNodes with multiple `model_spec`s. This diff avoids the `model_spec_to_gen_from` call for node-based GS and uses it only for step-based GS, where this is not an issue. Differential Revision: D56732974 Reviewed By: mgarrard
Summary: Updates the behavior to match the docstring. Previously, this would call `model_spec_to_gen_from`, which could lead to fitting multiple models if the node had multiple model specs. The return type was always `str` rather than `Optional[str]` suggested by the type hints. Reviewed By: mgarrard Differential Revision: D56735619
|
This pull request was exported from Phabricator. Differential Revision: D56735619 |
saitcakmak
force-pushed
the
export-D56735619
branch
from
a69f1a4 to
b6f77f4
Compare
|
This pull request has been merged in 9ba941c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates the behavior to match the docstring. Previously, this would call
model_spec_to_gen_from, which could lead to fitting multiple models if the node had multiple model specs. The return type was alwaysstrrather thanOptional[str]suggested by the type hints.Differential Revision: D56735619