Replace List with Sequence when typing MBM #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Sequence is a more permissive type hint that works better with Pyre. For example, Pyre complains if we pass `List[MultiTaskDataset]` to a function that expects `List[SupervisedDataset]` (even though `MultiTaskDataset` is a subclass of `SupervisedDataset`) but it is ok with this if we use `Sequnce[SupervisedDataset]` as the type hint. Differential Revision: D56498406
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56498406 |
saitcakmak
force-pushed
the
export-D56498406
branch
from
6f3f336 to
1a26d27
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56498406 |
|
This pull request has been merged in 2d9c738. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Sequence is a more permissive type hint that works better with Pyre. For example, Pyre complains if we pass
List[MultiTaskDataset]to a function that expectsList[SupervisedDataset](even thoughMultiTaskDatasetis a subclass ofSupervisedDataset) but it is ok with this if we useSequnce[SupervisedDataset]as the type hint.Differential Revision: D56498406