Retain original data timestamp in Experiment.clone_with #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54876890 |
facebook-github-bot
added
CLA Signed
Summary: Previously, this would attach the data using `Experiment.attach_data` which would create a new timestamp for the attached data. Directly assigning `Expeirment._data_by_trial` allows us to retain the original timestamp that the data was attached at. Differential Revision: D54876890
saitcakmak
force-pushed
the
export-D54876890
branch
from
da6e2e0 to
ac9c652
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54876890 |
|
This pull request has been merged in cbb17c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, this would attach the data using
Experiment.attach_datawhich would create a new timestamp for the attached data. Directly assigningExpeirment._data_by_trialallows us to retain the original timestamp that the data was attached at.Differential Revision: D54876890