Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release of ax-platform is raising ModuleNotFoundError #387

Closed
richardliaw opened this issue Sep 30, 2020 · 6 comments
Closed

New release of ax-platform is raising ModuleNotFoundError #387

richardliaw opened this issue Sep 30, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@richardliaw
Copy link
Contributor

Is there a workaround for this?

(base) ➜  ~ git:(master) ✗ pip install -U ax-platform
Collecting ax-platform
  Downloading https://files.pythonhosted.org/packages/22/94/4664137378b701f1b5fe2612e2b111a20c05e88abaeeef9e44eee048ffa8/ax_platform-0.1.15-py3-none-any.whl (599kB)
     |████████████████████████████████| 604kB 3.0MB/s
Requirement already satisfied, skipping upgrade: pandas in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (1.0.5)
Requirement already satisfied, skipping upgrade: jinja2 in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (2.11.2)
Requirement already satisfied, skipping upgrade: plotly in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (4.9.0)
Requirement already satisfied, skipping upgrade: scipy in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (1.4.1)
Requirement already satisfied, skipping upgrade: botorch>=0.2.2 in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (0.3.0)
Requirement already satisfied, skipping upgrade: scikit-learn in ~/miniconda3/lib/python3.7/site-packages (from ax-platform) (0.22.2)
Requirement already satisfied, skipping upgrade: python-dateutil>=2.6.1 in ~/miniconda3/lib/python3.7/site-packages (from pandas->ax-platform) (2.8.1)
Requirement already satisfied, skipping upgrade: numpy>=1.13.3 in ~/miniconda3/lib/python3.7/site-packages (from pandas->ax-platform) (1.18.1)
Requirement already satisfied, skipping upgrade: pytz>=2017.2 in ~/miniconda3/lib/python3.7/site-packages (from pandas->ax-platform) (2020.1)
Requirement already satisfied, skipping upgrade: MarkupSafe>=0.23 in ~/miniconda3/lib/python3.7/site-packages (from jinja2->ax-platform) (1.1.1)
Requirement already satisfied, skipping upgrade: six in ~/miniconda3/lib/python3.7/site-packages (from plotly->ax-platform) (1.12.0)
Requirement already satisfied, skipping upgrade: retrying>=1.3.3 in ~/miniconda3/lib/python3.7/site-packages (from plotly->ax-platform) (1.3.3)
Requirement already satisfied, skipping upgrade: torch>=1.5 in ~/miniconda3/lib/python3.7/site-packages (from botorch>=0.2.2->ax-platform) (1.5.1)
Requirement already satisfied, skipping upgrade: gpytorch>=1.1.1 in ~/miniconda3/lib/python3.7/site-packages (from botorch>=0.2.2->ax-platform) (1.2.0)
Requirement already satisfied, skipping upgrade: joblib>=0.11 in ~/miniconda3/lib/python3.7/site-packages (from scikit-learn->ax-platform) (0.15.1)
Requirement already satisfied, skipping upgrade: future in ~/miniconda3/lib/python3.7/site-packages (from torch>=1.5->botorch>=0.2.2->ax-platform) (0.18.2)
Installing collected packages: ax-platform
  Found existing installation: ax-platform 0.1.14
    Uninstalling ax-platform-0.1.14:
      Successfully uninstalled ax-platform-0.1.14
Successfully installed ax-platform-0.1.15
(base) ➜  ~ git:(master) ✗ ipython
iPython 3.7.4 (default, Aug 13 2019, 15:17:50)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.16.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import ax
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-709cd9cacec7> in <module>
----> 1 import ax

~/miniconda3/lib/python3.7/site-packages/ax/__init__.py in <module>
     29     Trial,
     30 )
---> 31 from ax.modelbridge import Models
     32 from ax.service import OptimizationLoop, optimize
     33 from ax.storage import load, save

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/__init__.py in <module>
      8 from ax.modelbridge import transforms
      9 from ax.modelbridge.base import ModelBridge
---> 10 from ax.modelbridge.factory import (
     11     Models,
     12     get_factorial,

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/factory.py in <module>
     20 from ax.modelbridge.multi_objective_torch import MultiObjectiveTorchModelBridge
     21 from ax.modelbridge.random import RandomModelBridge
---> 22 from ax.modelbridge.registry import (
     23     Cont_X_trans,
     24     Models,

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/registry.py in <module>
     46 from ax.models.torch.botorch_kg import KnowledgeGradient
     47 from ax.models.torch.botorch_mes import MaxValueEntropySearch
---> 48 from ax.models.torch.botorch_modular.model import BoTorchModel
     49 from ax.models.torch.botorch_moo import MultiObjectiveBotorchModel
     50 from ax.utils.common.kwargs import (

ModuleNotFoundError: No module named 'ax.models.torch.botorch_modular'
@lena-kashtelyan
Copy link
Contributor

Hi, @richardliaw, thanks so much for letting us know! I believe this is due to our forgetting to bump our BoTorch version requirement. If you upgrade botorch package to 0.3.1, this should go away. Let me know if it doesn't!

@lena-kashtelyan lena-kashtelyan self-assigned this Sep 30, 2020
@lena-kashtelyan lena-kashtelyan added the bug Something isn't working label Sep 30, 2020
@richardliaw
Copy link
Contributor Author

@lena-kashtelyan thanks for the fast response. I think it doesn't work actually:

Installing collected packages: torch, botorch
  Found existing installation: torch 1.5.1
    Uninstalling torch-1.5.1:
      Successfully uninstalled torch-1.5.1
  Found existing installation: botorch 0.3.0
    Uninstalling botorch-0.3.0:
      Successfully uninstalled botorch-0.3.0
Successfully installed botorch-0.3.1 torch-1.6.0

In [4]: exit
(base) ➜  ray git:(master) ✗
(base) ➜  ray git:(master) ✗ ipython
Python 3.7.4 (default, Aug 13 2019, 15:17:50)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.16.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import ax
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-709cd9cacec7> in <module>
----> 1 import ax

~/miniconda3/lib/python3.7/site-packages/ax/__init__.py in <module>
     29     Trial,
     30 )
---> 31 from ax.modelbridge import Models
     32 from ax.service import OptimizationLoop, optimize
     33 from ax.storage import load, save

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/__init__.py in <module>
      8 from ax.modelbridge import transforms
      9 from ax.modelbridge.base import ModelBridge
---> 10 from ax.modelbridge.factory import (
     11     Models,
     12     get_factorial,

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/factory.py in <module>
     20 from ax.modelbridge.multi_objective_torch import MultiObjectiveTorchModelBridge
     21 from ax.modelbridge.random import RandomModelBridge
---> 22 from ax.modelbridge.registry import (
     23     Cont_X_trans,
     24     Models,

~/miniconda3/lib/python3.7/site-packages/ax/modelbridge/registry.py in <module>
     46 from ax.models.torch.botorch_kg import KnowledgeGradient
     47 from ax.models.torch.botorch_mes import MaxValueEntropySearch
---> 48 from ax.models.torch.botorch_modular.model import BoTorchModel
     49 from ax.models.torch.botorch_moo import MultiObjectiveBotorchModel
     50 from ax.utils.common.kwargs import (

ModuleNotFoundError: No module named 'ax.models.torch.botorch_modular'

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this issue Sep 30, 2020
Summary: Addresses facebook#387

Reviewed By: sdsingh

Differential Revision: D24025000

fbshipit-source-id: 54ceaf70414d92be72e7b9e811d58d563245b261
@lena-kashtelyan
Copy link
Contributor

That's perplexing, let me investigate.

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this issue Sep 30, 2020
Summary:
Pull Request resolved: facebook#389

Addresses facebook#387

Reviewed By: sdsingh

Differential Revision: D24025000

fbshipit-source-id: bfca9d156002d5e58e34fb8db821c412c3da2502
facebook-github-bot pushed a commit that referenced this issue Sep 30, 2020
Summary:
Pull Request resolved: #389

Addresses #387

Reviewed By: sdsingh

Differential Revision: D24025000

fbshipit-source-id: 978177341cf638c132b84505013376db54f5aea1
@stevemandala
Copy link
Contributor

Update: Found the source of the problem, currently working on getting a fix committed (should be out in a bit) after which we will release a new version.

facebook-github-bot pushed a commit that referenced this issue Sep 30, 2020
Summary: In #387, users are having issue importing from the botorch_modular module. Maybe it's because of the missing __init__.py. But I have no clue how this works **without** it . . .

Reviewed By: lena-kashtelyan

Differential Revision: D24031280

fbshipit-source-id: 3cbfebf3f756927a78979941676d8c2aa34ac2f7
@stevemandala
Copy link
Contributor

Fix is out 16cb868, also released a new version (v0.1.16) which should be available from PyPl shortly

@richardliaw
Copy link
Contributor Author

richardliaw commented Oct 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants