Add delrelativize transform to EBAshr (#3314)

Summary:
Pull Request resolved: #3314

There was a bug that popped up recently that danielcohenlive noticed related to SOO exp not being able to generate candidates. This experiment ended up having a relative constraint in the opt config, which looks like we overlooked. We add that here

Reviewed By: danielcohenlive

Differential Revision: D69221574

fbshipit-source-id: 145bd619d396fd12f3c53f05459b32a2a5f4cbd8

ax/modelbridge/registry.py

@@ -117,11 +117,17 @@
 Discrete_X_trans: list[type[Transform]] = [IntRangeToChoice]
 
 EB_ashr_trans: list[type[Transform]] = [
+    Derelativize,  # necessary to support relative constraints
+    # scales data from multiple trials since we currently don't filter to single
+    # trial data
     TransformToNewSQ,
+    # Ensure we pass unique arms to EBAshr. This assumes treatment effects are
+    # stationarity, but also should help with estimating the task-task covariance.
     MergeRepeatedMeasurements,
     SearchSpaceToChoice,
 ]
 
+# TODO: @mgarrard remove this once non-gs methods are reaped
 rel_EB_ashr_trans: list[type[Transform]] = [
     Relativize,
     MergeRepeatedMeasurements,

ax/utils/testing/core_stubs.py

@@ -253,19 +253,23 @@ def get_branin_experiment(
     with_completed_batch: bool = False,
     with_completed_trial: bool = False,
     num_arms_per_trial: int = 15,
+    with_relative_constraint: bool = False,
 ) -> Experiment:
     search_space = search_space or get_branin_search_space(
         with_fidelity_parameter=with_fidelity_parameter,
         with_choice_parameter=with_choice_parameter,
         with_str_choice_param=with_str_choice_param,
         with_parameter_constraint=with_parameter_constraint,
     )
+
     exp = Experiment(
         name="branin_test_experiment" if named else None,
         search_space=search_space,
         optimization_config=(
-            get_branin_optimization_config(minimize=minimize)
-            if has_optimization_config
+            get_branin_optimization_config(
+                minimize=minimize, with_relative_constraint=with_relative_constraint
+            )
+            if has_optimization_config or with_relative_constraint
             else None
         ),
         runner=SyntheticRunner(),
@@ -1716,8 +1720,20 @@ def get_optimization_config_no_constraints(
     )
 
 
-def get_branin_optimization_config(minimize: bool = False) -> OptimizationConfig:
-    return OptimizationConfig(objective=get_branin_objective(minimize=minimize))
+def get_branin_optimization_config(
+    minimize: bool = False, with_relative_constraint: bool = False
+) -> OptimizationConfig:
+    outcome_constraint = []
+    if with_relative_constraint:
+        outcome_constraint.append(
+            get_outcome_constraint(
+                metric=get_branin_metric(name="branin_d"), relative=True
+            )
+        )
+    return OptimizationConfig(
+        objective=get_branin_objective(minimize=minimize),
+        outcome_constraints=outcome_constraint,
+    )
 
 
 def _validate_num_objectives(num_objectives: int) -> None: