Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading snapshot with term serializer #18

Merged

Conversation

dvic
Copy link
Collaborator

@dvic dvic commented Jan 23, 2023

No description provided.

@dvic
Copy link
Collaborator Author

dvic commented Jan 23, 2023

I encountered an issue when using a term serializer and a custom content type. Failing test is included (if fix is not applied). With the JSON 'hack' mentioned in the code I'm not sure if this is the right fix, but it works for me :)

@fabriziosestito
Copy link
Owner

@dvic many thanks for this, the solution proposed is great. I've just added some comments then we are ready to merge.

@dvic
Copy link
Collaborator Author

dvic commented Jan 24, 2023

@dvic many thanks for this, the solution proposed is great. I've just added some comments then we are ready to merge.

👍 done, I've made the struct check also more specific, it should check specifically for %SnapshotData{} right?

Copy link
Owner

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziosestito
Copy link
Owner

@dvic I will wait a few days before the release to see if there is something else I need to include

@fabriziosestito fabriziosestito merged commit 5da72b4 into fabriziosestito:main Jan 24, 2023
@fabriziosestito
Copy link
Owner

@dvic I've just released v0.1.2 on hex, which includes your patch.
Note that one test is still failing, since this adapter does not support partitioning. The tests are inherited from commanded dep and there is no way to skip them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants