-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading snapshot with term serializer #18
Fix reading snapshot with term serializer #18
Conversation
I encountered an issue when using a term serializer and a custom content type. Failing test is included (if fix is not applied). With the JSON 'hack' mentioned in the code I'm not sure if this is the right fix, but it works for me :) |
@dvic many thanks for this, the solution proposed is great. I've just added some comments then we are ready to merge. |
👍 done, I've made the struct check also more specific, it should check specifically for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dvic I will wait a few days before the release to see if there is something else I need to include |
@dvic I've just released v0.1.2 on hex, which includes your patch. |
No description provided.