refactor(): cache state => rm isTextObject
#8952
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Build Stats
|
ShaMan123
commented
May 22, 2023
src/shapes/Text/Text.ts
Outdated
Comment on lines
574
to
578
| // IMHO in these lines we are using zoomX and zoomY not the this version. | ||
| const additionalWidth = | ||
| data.additionalSize.width + this.getHeightOfLine(0) * this.zoomX!; | ||
| const additionalHeight = | ||
| data.additionalSize.height + this.getHeightOfLine(0) * this.zoomY!; |
Contributor
Author
There was a problem hiding this comment.
this is a comment you left here
Contributor
ShaMan123
commented
May 25, 2023
Contributor
Author
ShaMan123
left a comment
ShaMan123
left a comment
There was a problem hiding this comment.
DONE after porting
Comment on lines
+1896
to
+1901
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| export interface Text< | ||
| Props extends TProps<TextProps> = Partial<TextProps>, | ||
| SProps extends SerializedTextProps = SerializedTextProps, | ||
| EventSpec extends ObjectEvents = ObjectEvents | ||
| > extends TextSVGExportMixin {} |
Contributor
Author
There was a problem hiding this comment.
typed the svg mixin
Comment on lines
290
to
299
| getSVGFontList() { | ||
| const fontList: Record<string, boolean> = { [this.fontFamily]: true }; | ||
| this.styles && | ||
| Object.values(this.styles).forEach((styleRow) => { | ||
| Object.values(styleRow).forEach(({ fontFamily = '' }) => { | ||
| fontList[fontFamily] = true; | ||
| }); | ||
| }); | ||
| return fontList; | ||
| } |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions. |
Contributor
Author
|
We disagreed on this so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#8931
Description
The last part of type assertion to handle.
I had to refactor the messy logic of
_updateCacheCanvasand extract from it a method that has no side effectsgetCacheStateso Text can override it.Apart from that is is only one more use of
isTextObjectfabric.js/src/canvas/StaticCanvas.ts
Lines 1319 to 1321 in a1f94b2
I extracted that logic to the text svg mixin =>
getSVGFontListChanges
Gist
In Action