Skip to content

Conversation

@luizzappa
Copy link
Contributor

Description

Add tests to poly custom control #8556

@luizzappa
Copy link
Contributor Author

github actions unit tests are failing because I introduced assert.close (asserting that a number is approximately equal to an expected number, within a given tolerance):

QUnit.assert.close = function(actual, expected, maxDifference, message) {
const actualDiff = (actual === expected) ? 0 : Math.abs(actual - expected),
result = actualDiff <= maxDifference;
message = message || (actual + " should be within " + maxDifference + " (inclusive) of " + expected + (result ? "" : ". Actual: " + actualDiff));
this.pushResult({
result,
actual: actualDiff,
expected: maxDifference,
message
})
};

@asturur
Copy link
Member

asturur commented Jan 13, 2023

oh thank you i wanted to follow up with this, but i m using all the time i have to finish ts and library build/package

expected: maxDifference,
message
})
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is useful

@asturur
Copy link
Member

asturur commented Jan 13, 2023

Something seems slightly off for browsers. Do you know what is it or do you need help?

@luizzappa
Copy link
Contributor Author

Okay, I inserted the assert.close method in the wrong file, so it wasn't accessible in firefox and chrome contexts. Fix f774766

It's good to go.

@stale
Copy link

stale bot commented Mar 20, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented May 21, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label May 21, 2023
@stale stale bot closed this Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issue marked as stale by the stale bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants