-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
BREAKING: Remove statefulCache and stateful #8573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build Stats
|
| 'fillRule', | ||
| 'paintFirst', | ||
| 'clipPath', | ||
| 'strokeUniform', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the overlab between stateful properties and cache properties.
Stateful properties can't be deleted since they are still needed to set group as dirty.
| const arrayContext = animate({ | ||
| startValue: [5], | ||
| byValue: [1], | ||
| endValue: [1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you found the ts tests
ShaMan123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
We can remove layout from stateProperties of group since group layout bubbles to its parents
|
so many tabs I litter messages |
Motivation
While we are not ready to let the stateful mixin go, we agree on removing the stateful support as a feature.
This PR removes Stateful support in order to simplify fabricJS code handling of changes.
On top of that we should optimize always for the common use case.
If you want stateful changes, there are less expensive way to have them compared to brute force saving and comparing of object trees.
Changes
Object.stateful is no more an option
Object.statefulCache is no more an option
Those were defaulted as fault since long, so if you didn't set them on true on purpose, this shouldn't affect you.
Gist
In Action