Skip to content

Conversation

@ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Aug 29, 2022

WIP

This is cool but as @asturur suggested artifacts are probably more straight forward and less messy
Check out the first comment made by the bot that points to visual diffs from ci test results (see Visual Test Result Diffs)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

Visual Test Result Diffs: node, chrome, firefox

Coverage after merging ci-visual-test-action into master will be

74.87%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
dist
   fabric.js73.43%69.08%81.98%74.87%10044, 10056, 10070, 10099, 10116–10117, 10120, 10129–10130, 10130, 10130–10131, 10133–10135, 10142, 10142, 10142–10144, 10146–10147, 10154–10156, 10183–10185, 10187–10188, 10191–10192, 10263, 10282–10284, 10286–10287, 10349, 1036, 10403, 10418, 10474, 10510–10511, 10517, 10521–10522, 10537, 10571, 10602–10603, 10627, 10635, 10701, 10722, 10754–10755, 10830–10831, 10834, 10839, 10861, 10861, 10861, 10861, 10861, 10861, 10861–10862, 10864–10865, 10865, 10865–10866, 10871, 10873, 10879, 10879, 10879, 10879, 10879–10880, 10882–10886, 10886, 10886–10888, 10890–10891, 10900, 10911, 10922, 10933, 10943–10946, 10954–10955, 10955, 10955–10956, 10958–10959, 10966, 10970, 1111, 1113–1114, 1116–1117, 1124, 1128, 1136, 11567, 11572, 116, 11614–11616, 11616, 11616, 11616, 11616, 11616–11617, 11630, 11630–11634, 11637, 11642–11643, 11691–11692, 11706, 11706, 1172, 1174, 1174, 1174, 1174, 1174, 11749, 11749, 11749, 1175, 11751, 11899, 11899, 119, 11900, 11911, 11998, 120, 12001, 12001, 12001–12002, 12005, 12008, 12008, 12008–12010, 12012–12015, 12042, 12048–12052, 12068–12069, 12071, 12073, 12076, 12095, 12098–12099, 121, 12100, 12103, 12119, 12125–12126, 12126, 12126, 12126, 12126, 12126, 12131, 12135–12136, 12147–12150, 12173, 12187, 12195, 12197–12198, 12213, 12213, 12213–12214, 12214–12216, 12229, 12229, 12229–12230, 12232–12233, 12243, 12243, 12243, 12243, 12243–12244, 12246, 12246, 12246–12247, 12247, 12247, 12247, 12247–12248, 12248, 12248–12249, 12252, 12254, 12254, 12254–12255, 12257, 12264–12266, 12292–12293, 12308, 12308–12309, 12312–12314, 12333–12350, 12369, 12454–12455, 12457–12458, 12463–12465, 12465, 12465, 12467–12468, 12489, 12492–12493, 12554–12555, 12559, 12639, 12648, 12653, 12690, 12791, 12791, 12791, 128, 12815–12816, 129, 129, 129, 129, 129, 129, 129, 12924, 12927, 12989, 12995, 130, 13002, 13009, 13015, 13021, 13028, 13035, 13041–13042, 13042, 13042, 13057–13058, 13066, 13075, 13075, 131, 13100–13103, 13141, 13184–13185, 13225–13226, 133, 13359–13360, 1341, 1341, 13427, 1343, 13505, 13597, 13660, 13663, 13716–13717, 13717, 13717, 13720, 13735, 13749, 13761–13762, 13764, 13776–13777, 13779, 13794, 13809–13810, 13812–13813, 13815–13816, 13826, 13836–13837, 13856, 13856, 13856, 13856, 13856, 13856, 13856, 13856, 13881, 13883, 13883–13885, 13915, 1393, 13938–13940, 13963, 13971, 13977–13978, 13998–13999, 14001–14002, 14004–14005, 14019, 14045, 14049, 14082–14083, 14117, 14138–14139, 14198, 14198, 14198, 14198, 14198, 14203–14211, 14253, 14306–14307, 14307, 14307, 14312, 14379–14380, 14416, 14425, 14446, 14446, 14446–14447, 14447, 14447, 14447, 14447–14448, 14454–14456, 14459–14460, 14473, 14473, 14473–14474, 14474, 14474, 14474, 14474–14475, 14481–14483, 14486–14487, 14500–14501, 14575, 14624, 14628, 14744–14748, 14752–14753, 14753, 14753–14754, 14754, 14754–14755, 14764, 14783–14784, 14784, 14784–14785, 14785, 14785–14786, 14788, 14788, 14788–14789, 14792, 14799, 14799, 14884, 14997, 15046, 15116, 15120, 1513, 15190, 15221–15226, 15247–15248, 15262, 15312–15313, 15315–15316, 15329–15330, 15335, 15337, 15339, 15341, 154, 15408, 15468, 15471, 15545–15546, 15546, 15546, 15546, 15546, 15549, 15551–15555, 15557, 15564, 15564, 15564–15565, 15567, 15574, 15616, 15620, 15645, 15645, 15645–15646, 15648–15649, 15680, 15684, 1574, 158, 158, 158, 158, 158–159, 15908, 15950, 15954, 16051–16052, 16118, 16121, 16128–16129, 16129, 16129–16131, 16133, 16133, 16133–16135, 16135, 16135–16137, 162, 162, 16227, 16232–16234, 16262–16263, 163, 163, 163, 163, 163, 16330, 16330, 16330–16331, 16333, 16333, 16333–16334, 16336–16337, 16337, 16337–16338, 16338, 16338, 16340–16341, 16343, 16346, 16373, 16373, 16373, 16373, 16373–16375, 16377, 164, 16400, 16402, 16424, 16424, 16459, 16494, 16494, 16494, 16497–16498, 16500, 16500, 16500, 16500, 16500, 16504, 16504, 16504, 16504, 16504–16507, 16507, 16507, 16507, 16507, 16507, 16509–16510, 16510, 16510, 16512–16513, 16515, 16522, 16522, 16522, 16524, 16526–16527, 16527, 16527, 16527, 16527–16528, 16528, 16528–16529, 16529, 16529, 16529, 16529–16530, 16540–16541, 16550, 16550, 16550, 16550, 16550–16551, 16551, 16551–16553, 16553–16554, 16554, 16571, 16571–16572, 16572, 16572, 16594–16595, 16595, 16595,

@ShaMan123
Copy link
Contributor Author

ShaMan123 commented Aug 29, 2022

@ShaMan123
Copy link
Contributor Author

This is great!
I will add an action that deletes the ci branches when the pr closes and update the coverage report action to include the diff urls

@ShaMan123
Copy link
Contributor Author

closed in favor of #8206

@ShaMan123 ShaMan123 closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants