-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
add a undo_redo lib #8073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a undo_redo lib #8073
Conversation
QJesus
commented
Jul 20, 2022
- fabric.Text.text cannot be null\undefined
- undo_redo extension
Can be a standalone PR |
lib/undo_redo.js
Outdated
| const ___setupCanvas = fabric.canvas.prototype.__setupCanvas; | ||
| fabric.canvas.prototype.__setupCanvas = function (serialized, enlivenedObjects, renderOnAddRemove, callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const ___setupCanvas = fabric.canvas.prototype.__setupCanvas; | |
| fabric.canvas.prototype.__setupCanvas = function (serialized, enlivenedObjects, renderOnAddRemove, callback) { | |
| const ___setupCanvas = fabric.Canvas.prototype.__setupCanvas; | |
| fabric.Canvas.prototype.__setupCanvas = function (serialized, enlivenedObjects, renderOnAddRemove, callback) { |
Nice lib idea! fabric.canvas should have uppercase C though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve some of these variable names. Names like t, v, and h aren't very human readable.
Some comments would be helpful as well to explain the purpose of each function and variables like undoredo.escape
|
I don't think history should be part of core. |
|
@QJesus I am very for contributions, hope I didn't put you down. |
|
Actually we wanted to think about a more simple way to tackle this, both on core and an external lib. We have to move forward with our schedule and as soon as the rollup pr is merged, we can get back to this. |
|
@QJesus Thanks for the pr, however as asturur explained this isn't quite the direction we want to take with an undoredo library. I'm going to close this PR for now, but we can revisit adding an official undoredo component once v6 is out of the gate. |