fix(): nested duplicated clipPath causes infinite recursion #10774
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Build Stats
|
|
Looking at this. |
|
is firefox flaky again? |
|
I spent some hour on this PR, i modified one example two highlight 2 issues:
For 1) i will open an issue and the problem is that the test now compare the rendering on browser and node of an imported svg, but it does not compare it to the actual svg. So all our svg import tests now are kind of useless. for 2) i have some test to do in mind, hopefully i can get back to it tonight. I may have accidentally committed some half backed idea in the code now. |
|
This is the svg this is the snapshot and it passes 
|
oh crap, that doesn't sound good |
I do not know when it broke. I think before the svg test had some code that was rendering it as an img and on the canvas and using that as reference. But it doesn't matter is going to be fixed. |
| const clipPathTag = clipPathElements[0].parentElement!; | ||
| const clipPathTag = clipPathElements[0].parentElement!.cloneNode( | ||
| true, | ||
| ) as HTMLElement; |
There was a problem hiding this comment.
this is new from me, i wanted to create a copy of the clipPath since we are adding to it transforms attributes depending on the element using it
| `matrix(${finalTransform.join(',')})`, | ||
| ); | ||
|
|
||
| const updatedProcessedClipPaths = new Set(processedClipPaths); |
There was a problem hiding this comment.
Do you remember why the new set each time?
There was a problem hiding this comment.
hm, don't really remember now
might be a brain fart that I had to do it
3 participants
another attempt to solve #10667 but now with visual tests as well
fixes #10659