Thunderbird conversations support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
January 24, 2013 17:24
…erent detection will be needed.
…i. Still for some reason message does not appear, to be tested.
Added some logging.
…the up, but we are going in good direction.
…e fail to parse. Therefore we strip the fragment from extracted uri if we happened to get one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not quite pull request, but I wanted to poke you to take a look at my changes and discuss them.
I managed to make bugmail working with Thunderbird Conversations ( https://addons.mozilla.org/en-US/thunderbird/addon/gmail-conversation-view/ - excellent plugin which gives some gmail-like experience but reorganizes message pane noticeably ). The changes are noticeable (new events must be subscribed, they provide different kind of information, interface must be modified differently) but should not spoil original code.
The code works, but so far works only for bugzilla, and is more a proof of concept than final solution (for example actual bugzilla-supporting code lies in overlay.js so far). I can work on moving it down to specific modules and refactoring them to reuse the code, but first I wanted to ask whether you are interested in supporting Conversations and open to accept noticeable code refactorings (for example APIs of tracker modules would need to change somewhat so they work properly with nsIMsgDBHdr and html-object data instead of message uri and document)
Best regards
Marcin