Skip to content

Fix high latency when websocket connection fails #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fusesource-ci merged 2 commits into from
Feb 9, 2017
Merged

Fix high latency when websocket connection fails #655

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ed83b
Fix high latency when websocket connection fails
foxish Feb 8, 2017
fc394c9
Added comment
foxish Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...lient/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@

import static io.fabric8.kubernetes.client.utils.Utils.isNotNullOrEmpty;
import static java.net.HttpURLConnection.HTTP_GONE;
import static java.net.HttpURLConnection.HTTP_OK;

public class WatchConnectionManager<T extends HasMetadata, L extends KubernetesResourceList<T>> implements Watch {

Expand Down Expand Up @@ -193,6 +194,13 @@ public void onFailure(IOException e, Response response) {
return;
}

if (response != null && response.code() == HTTP_OK) {
Copy link
Member

@iocanel iocanel Feb 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would group this block with the rest of the if then else that take place when response != null.

Definitely not a blocker though!

queue.add(new KubernetesClientException("Received 200 on WebSocket connection",
response.code(), null));
response.body().close();
return;
}

if (response != null) {
// We only need to queue startup failures.
Status status = OperationSupport.createStatus(response);
Expand Down