Skip to content

Conversation

@rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 20, 2024

Description

Related to eclipse-jkube/jkube#3142

Fix #6068

  • Add currentContext and contexts arguments to Config constructor in order to pass them to child class OpenShiftConfig
  • Add values for username, oauthToken, and currentContext to Config created by the Kubernetes Mock Server for
    KubernetesClient used in tests

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

rohanKanojia and others added 2 commits June 26, 2024 06:02
…ernetesMockServer's initConfig

Add values for username, oauthToken and currentContext to Config created
by the Kubernetes Mock Server for KubernetesClient used in tests

Signed-off-by: Rohan Kumar <[email protected]>
@sonarqubecloud
Copy link

@manusa manusa added this to the 7.0.0 milestone Jun 26, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit b9ee9b0 into fabric8io:main Jun 26, 2024
@rohanKanojia rohanKanojia deleted the pr/issue6068 branch June 26, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KubernetesMockServer provides incomplete Configuration while creating test Config for KubernetesClient

2 participants