fix: swallow rejected execution after shutdown#6063
Merged
manusa merged 1 commit intofabric8io:mainfrom Jun 25, 2024
Merged
Conversation
shawkins
requested review from
manusa,
oscerd,
rohanKanojia and
sunix
as code owners
9 tasks
oscerd
approved these changes
Jun 19, 2024
|
rohanKanojia
approved these changes
Jun 19, 2024
csviri
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The handling to make the informer behavior deterministic allows for the cache call to happen after shutdown. The simplest thing to do is to just swallow the rejected execution exception.
closes: #6059
Type of change
test, version modification, documentation, etc.)
Checklist