Allow to deserialize more valid RFC3339 date-time and make the format customizable#5384
Merged
manusa merged 1 commit intofabric8io:mainfrom Aug 11, 2023
Merged
Allow to deserialize more valid RFC3339 date-time and make the format customizable#5384manusa merged 1 commit intofabric8io:mainfrom
manusa merged 1 commit intofabric8io:mainfrom
Conversation
andreaTP
commented
Aug 11, 2023
| @Parameter(property = "fabric8.java-generator.enum-uppercase", required = false) | ||
| Boolean enumUppercase = null; | ||
|
|
||
| /** |
Member
Author
There was a problem hiding this comment.
This is a leftover, not used around hence not a breaking change.
Member
Author
|
Ideally, this fix should be backported to a 6.8.1 release, cc. @manusa . |
manusa
approved these changes
Aug 11, 2023
rohanKanojia
approved these changes
Aug 11, 2023
|
SonarCloud Quality Gate failed.
|
Member
Author
|
For the records:
all in all, I'm happy to make this configurable so that users will be able to tweak it depending on their environment/use-case. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.











Description
Fix #5382
Given the fact that the specification allows for even more special cases (e.g. using lower-case 't' and 's'), here we propose to cover the most common formats with defaults, but we enable the users to customize (separately) the format for serialization and deserialization of
date-timefields.Type of change
test, version modification, documentation, etc.)
Checklist