Skip to content

(Chore) : Update okhttp version to 3.12.0#1301

Merged
fusesource-ci merged 1 commit intofabric8io:masterfrom
rohanKanojia:updateokhttp
Feb 8, 2019
Merged

(Chore) : Update okhttp version to 3.12.0#1301
fusesource-ci merged 1 commit intofabric8io:masterfrom
rohanKanojia:updateokhttp

Conversation

@rohanKanojia
Copy link
Copy Markdown
Member

@rohanKanojia rohanKanojia commented Dec 21, 2018

No description provided.

oscerd
oscerd suggested changes Dec 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I believe the Karaf feature needs to be updated.

@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Dec 21, 2018

@oscerd: Getting this weird error in platform/ module on my machine: https://pastebin.com/Av1vYUp9 . Do you any idea why it's referring to 4.1.0-SNAPSHOT

@oscerd
Copy link
Copy Markdown
Member

oscerd commented Dec 21, 2018

This is because the test is trying to install the snapshot in a Karaf container.. So you need to check the Karaf feature and update the feature dependency accordingly to okhttp-client 3.12.0

@oscerd
Copy link
Copy Markdown
Member

oscerd commented Dec 21, 2018

And Welcome to OSGi!

@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Dec 21, 2018

@oscerd : What's OSG?

@oscerd
Copy link
Copy Markdown
Member

oscerd commented Dec 21, 2018

This https://www.osgi.org/

Karaf is an OSGi container.

@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Dec 21, 2018

ok, thanks. let me check and update

@oscerd
Copy link
Copy Markdown
Member

oscerd commented Dec 21, 2018

https://github.com/fabric8io/kubernetes-client/blob/master/platforms/karaf/features/src/main/resources/feature.xml

You have to work on this mainly

@rohanKanojia rohanKanojia force-pushed the updateokhttp branch 3 times, most recently from 3caf28d to 456c309 Compare January 30, 2019 16:38
@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Jan 31, 2019

@oscerd : on mockwebserver 0.1.0-SNAPSHOT(with okhttp 3.12.1) build seems to be passing, we need to release mockwebserver and use released version here

@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Feb 1, 2019

I've updated pom with the latest version of mockwebserver 0.1.1

@rohanKanojia rohanKanojia added needs code review Pull requests which are waiting for review and removed changes requested wip labels Feb 1, 2019
@rohanKanojia
Copy link
Copy Markdown
Member Author

rohanKanojia commented Feb 8, 2019

[merge]

@fusesource-ci fusesource-ci merged commit 22844fc into fabric8io:master Feb 8, 2019
@rohanKanojia rohanKanojia removed the needs code review Pull requests which are waiting for review label Apr 10, 2019
@igorcalabria igorcalabria mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iocanel iocanel iocanel approved these changes

@lordofthejars lordofthejars Awaiting requested review from lordofthejars

+1 more reviewer

@oscerd oscerd oscerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohanKanojia @oscerd @iocanel @fusesource-ci