Support error websocket channel
#1045
Conversation
|
ok to test |
|
retest |
|
Thanks @giannello ! It can get confusing given that there's already
And is the header |
giannello
changed the title
error websocket channelerror websocket channel
|
@carlossg added you as a collaborator in case you want to submit patches. Will take a look at the classes you mentioned tomorrow. |
|
In the meantime and given how many name changes are involved I'd love to hear from the maintainers before implementing the next changes |
|
I have added the needed methods, and the implementation on jenkinsci/kubernetes-plugin#300 to use them |
| if (err != null) { | ||
| err.write(byteString.toByteArray()); | ||
| if (error != null) { | ||
| error.write(byteString.toByteArray()); |
There was a problem hiding this comment.
this is the interesting part, not sending error stream to stderr stream
To get error messages as json
|
This is ready, tests in kubernetes-plugin are passing using the new methods, would love to hear about the API changes and method naming from a maintainer @iocanel ? |
giannello
changed the title
error websocket channelerror websocket channel
|
ping @iocanel |
|
I'm wondering if there is anything a random outsider could do to help push this forward? We use Jenkins to build Docker images using workers allocated via the Kubernetes plugin. However due to jenkinsci/kubernetes-plugin#300, which in turn depends on this issue, we're doing a manual build of the Kubernetes plugin with these fixes applied. It would be great to have these merged and included in upcoming releases. |
|
Don't know how I missed this.
Will have a look shortly.
…On Mon, Apr 23, 2018, 23:34 Caleb Delnay ***@***.***> wrote:
I'm wondering if there is anything a random outsider could do to help push
this forward?
We use Jenkins to build Docker images using workers allocated via the
Kubernetes plugin. However due to jenkinsci/kubernetes-plugin#300
<jenkinsci/kubernetes-plugin#300>, which in turn
depends on this issue, we're doing a manual build of the Kubernetes plugin
with these fixes applied. It would be great to have these merged and
included in upcoming releases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1045 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYiWKpFjWGO1cFWutBr5g1R48gEMLvrks5trjrXgaJpZM4S6GoM>
.
|
|
Ping @bparees |
|
@piyush1594 @iocanel bump, we definitely want to help enable the kubernetes pipeline plugin. |
|
I wonder if it would be useful to avoid all the renaming for the sake of simplicity first so you can better see the actual changes needed |
|
I can push a less intrusive change, will find some time this afternoon to find a better naming. |
|
ok to test |
|
@piyush1594 @rohanKanojia @hrishin take a look at this PR. |
|
any ETA for merging and releasing? |
|
@giannello @carlossg: Apologies for the long delay. Since my main concern was naming and its addressed I'll merge asap. |
|
@iocanel how long until it makes it into a release ? |
|
Hey, @iocanel Thinking of releasing the client. We need to bump the minor version or it is not required for the time being |
|
Hey @carlossg Kubernetes Client 3.2.0 released which have this feature. |
This PR stems from jenkins-kubernetes not being able to properly deal with the return code when
execing into a container. The kubernetes-client doesn't provide a separate pipe for the error channel exposed over the websocker, merging it withstderrinstead.This changeset exposes the
errorchannel as a separate stream, and renames the others to keep a consistent naming strategy. Theresizechannel is deliberately ignored.