-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readiness utility should be able to support extension #2718
Comments
Umm, I think we do have Readiness supported for OpenShift resources[0]. |
That's awesome! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
Removing the never stale. We should determine if this worth pursuing on its own, or if it's sufficient to point people towards using their own predicate (not via an spi) for isReady and use watiForCondition instead of waitUntilReady - along with some further javadocs for isReady and waitUntilReady. Given some of the confusion with what isReady is supposed to do (#3474), it may be best just to direct people toward using their own predicates and leave the built-in readiness as is for now. It does appear some of the extension models have status ready and/or replica fields - it would be nice where applicable to at least put a static method for that resource type on the XXXClient interface. |
We should encourage users to rely on the
So yes, +1.
|
Currently the readiness utility only supports kubernetes resources.
We should use the spi in order to optionally extend the behavior to openshift, knative etc resources.
The text was updated successfully, but these errors were encountered: