Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness utility should be able to support extension #2718

Closed
iocanel opened this issue Jan 12, 2021 · 6 comments
Closed

Readiness utility should be able to support extension #2718

iocanel opened this issue Jan 12, 2021 · 6 comments

Comments

@iocanel
Copy link
Member

iocanel commented Jan 12, 2021

Currently the readiness utility only supports kubernetes resources.

We should use the spi in order to optionally extend the behavior to openshift, knative etc resources.

@rohanKanojia
Copy link
Member

@iocanel
Copy link
Member Author

iocanel commented Jan 12, 2021

That's awesome!
I think that we need to use the spi, so that we have a signle readiness utility exposed.

@stale
Copy link

stale bot commented May 6, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale
Copy link

stale bot commented Aug 4, 2021

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@shawkins
Copy link
Contributor

Removing the never stale. We should determine if this worth pursuing on its own, or if it's sufficient to point people towards using their own predicate (not via an spi) for isReady and use watiForCondition instead of waitUntilReady - along with some further javadocs for isReady and waitUntilReady.

Given some of the confusion with what isReady is supposed to do (#3474), it may be best just to direct people toward using their own predicates and leave the built-in readiness as is for now.

It does appear some of the extension models have status ready and/or replica fields - it would be nice where applicable to at least put a static method for that resource type on the XXXClient interface.

@manusa
Copy link
Member

manusa commented May 30, 2023

isReady is an internal, subjective concept of the Fabric8 client which might or might not match what other tools consider as a Ready Kubernetes object (kubectl, Kubernetes dashboard(s), and so on).

We should encourage users to rely on the waitUntilConditon and other methods.

Given some of the confusion with what isReady is supposed to do (#3474), it may be best just to direct people toward using their own predicates and leave the built-in readiness as is for now.

So yes, +1.

It does appear some of the extension models have status ready and/or replica fields - it would be nice where applicable to at least put a static method for that resource type on the XXXClient interface.

I think this is aligned with the similar #3586 (and #3816)

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 2, 2023
@manusa manusa closed this as completed in 8707825 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants