fix run-java.sh broken auto_detect_jar_file to really find WAR (#79) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhuss this, hopefully, fixes #79 for good.. because #81 was wrong, it fails the self-test in fabric8io-images/s2i@master...vorburger:example-spring-gradle which I'm adding over in fabric8io-images/s2i#123 ... I'm just slightly confused as to why that BATS based self test didn't catch this, but anyway; this fixes the "real" (E2E) test over in fabric8io-images/s2i, which is the goal |
|
Thanks for the merge and 1.3.2 release - this lets me progress and wrap up fabric8io-images/s2i#123 ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.