Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for dmp plugins + fix Posix permission issue #71

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Jul 2, 2018

No description provided.

@rhuss
Copy link
Contributor Author

rhuss commented Jul 2, 2018

@vsfalexanderpilch this PR should fix the permission issue on Windows (by probing for a Posixfilesystem). Unfortunately I don't have a Windows system handy right now, it would be super awesome if you could verify whether this PR fixes issue #69 .

If you verify that it works, I'm happy to create a release so that this can be directly used with dmp.

Thanks !

@vsfalexanderpilch
Copy link

@rhuss It's working fine on windows. The script is located at target\docker-extra\run-java\run-java.sh. Could you please also release to maven central? Thanks

@rhuss
Copy link
Contributor Author

rhuss commented Jul 3, 2018

@vsfalexanderpilch cool thanks !. Yes I'm going to release 1.2.2 in a minute and it will pop on Maven central s

The script is located at target\docker-extra\run-java\run-java.sh.

Yes, that's by intention so that it's easier to use separate dmp plugins easily. The next one I will add is one for Jolokia and/or Prometheus instrumentation (run-java.sh has a hook for this.

@rhuss rhuss merged commit 7ff9d32 into fabric8io-images:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants