Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Ensure /apps API old and new formats can run in same WIT #1868

Merged
merged 3 commits into from
Jan 25, 2018

Conversation

stooke
Copy link
Contributor

@stooke stooke commented Jan 25, 2018

This PR addresses issue #1867.

Various implementation files, directories, function and type names are renamed so that the JSON-API breaking change can co-exist with the old API.
After the UI has been updated (and deployed all the way to production) to use the new JSON-API endpoints (which are not yet merged into WIT/master), then this code can be deleted in a future PR.

@fabric8cd
Copy link

@stooke snapshot fabric8-wit image is available for testing. docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1868-1

Copy link
Contributor

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks safe: just renaming types.

@xcoulon xcoulon merged commit 339480b into fabric8-services:master Jan 25, 2018
@codecov-io
Copy link

Codecov Report

Merging #1868 into master will not change coverage.
The diff coverage is 39.13%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files         139      139           
  Lines       13138    13138           
=======================================
  Hits         8064     8064           
  Misses       4354     4354           
  Partials      720      720
Impacted Files Coverage Δ
controller/apps_osioclient.go 0% <0%> (ø) ⬆️
controller/apps.go 0% <0%> (ø) ⬆️
kubernetesV1/apps_kubeclient.go 22.77% <39.13%> (ø)
kubernetesV1/apps_metrics.go 54.38% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fa6d0...2552263. Read the comment docs.

@stooke stooke deleted the jst2api branch January 25, 2018 21:34
stooke added a commit to stooke/fabric8-wit that referenced this pull request Jan 26, 2018
This patch renames some more types that were missed in PR fabric8-services#1868
xcoulon pushed a commit that referenced this pull request Jan 26, 2018
…1869)

This patch renames some more types that were missed in PR #1868
xcoulon pushed a commit that referenced this pull request Feb 8, 2018
* Eliminate some more duplicate names for deployments API refactoring

This patch renames some more types that were missed in PR #1868

* remove unused /apps API

The /apps API has been replaced by the JSON-API conformant version /deployments.

Fixes #1889
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants